[PATCH 2/3] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0
Sergei Shtylyov
sergei.shtylyov at cogentembedded.com
Wed Apr 9 19:11:52 UTC 2014
On 04/09/2014 11:02 PM, Dan Carpenter wrote:
>>> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/core/rtw_recv.c
>>> index 01fcabc..61084d6 100644
>>> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
>>> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
>>> @@ -551,7 +551,7 @@ static struct recv_frame *portctrl(struct adapter *adapter,
>>> struct sta_info *psta;
>>> struct sta_priv *pstapriv;
>>> struct recv_frame *prtnframe;
>>> - u16 ether_type = 0;
>>> + u16 ether_type;
>> I suggest:
>> u16 ethertype;
> I don't understand this suggestion. Why is that name prefered?
Sorry, I've managed to somehow remove the underscore. :-/
My real suggestion was to replace the tab with a space.
> regards,
> dan carpenter
WBR, Sergei
More information about the devel
mailing list