[PATCH] staging: speakup: fix misuse of kstrtol() in handle_goto()

[DaeSeok Youn]

2014-04-09 20:39 GMT+09:00, Dan Carpenter <dan.carpenter at oracle.com>:
> On Wed, Apr 09, 2014 at 07:45:46PM +0900, Daeseok Youn wrote:
>>
>> A string of goto_buf has a number followed by x or y.
>> e.g. "3x" means move 3 lines down.
>> The kstrtol() returns an error(-EINVAL) with this string so
>> go_pos has unsigned a value of that error.
>> And also "*cp" has not expected value.
>>
>
> Good catch.  This was introduced when we changed the simple_strtoul() to
> kstrtol().

Thanks! :-)

>
> Reviewed-by: Dan Carpenter <dan.carpenter at oracle.com>
>
> Did you find this bug by testing or through reading the code?
Actually, I couldn't test. I have looked the code for checking sparse
warnings and found this bug.

Regards,
Daeseok Youn

>
> regards,
> dan carpenter
>
>