staging-next: r8723au: Kconfig related nitpicks

Jes Sorensen Jes.Sorensen at redhat.com
Mon Apr 7 09:25:11 UTC 2014


Paul Bolle <pebolle at tiscali.nl> writes:
> Larry,
>
> 0) I stumbled on two minor Kconfig related issues in the r8723au driver
> in staging-next.
>
> 1) drivers/staging/rtl8723au/include/drv_types.h
> Why is CONFIG_BR_EXT used? I couldn't find a Kconfig symbol BR_EXT nor a
> preprocessor define for CONFIG_BR_EXT.

Hi Paul,

Most likely because we missed that instance when we ripped it out :)

> 2) drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
> And why is CONFIG_DEBUG_CFG80211 used? I also couldn't find a Kconfig
> symbol DEBUG_CFG80211 nor a preprocessor define for
> CONFIG_DEBUG_CFG80211.

If it's not used, it should be ripped out.

We've been going through this code for a while ripping things out that
are unnecessary and rewriting bad code, but there is still plenty that
needs fixing up.

Cheers,
Jes


More information about the devel mailing list