[PATCH] imx-hdmi: Make checkpatch happy

Fabio Estevam festevam at gmail.com
Sat Apr 5 15:50:22 UTC 2014


From: Fabio Estevam <fabio.estevam at freescale.com>

Fix the following checkpatch warnings:

WARNING: Missing a blank line after declarations
#162: FILE: drivers/staging/imx-drm/imx-hdmi.c:162:
+	u8 val = hdmi_readb(hdmi, reg) & ~mask;
+	val |= data & mask;

WARNING: Missing a blank line after declarations
#663: FILE: drivers/staging/imx-drm/imx-hdmi.c:663:
+	unsigned char val = 0;
+	val = hdmi_readb(hdmi, HDMI_IH_I2CMPHY_STAT0) & 0x3;

total: 0 errors, 2 warnings, 1773 lines checked

Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
---
 drivers/staging/imx-drm/imx-hdmi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/imx-drm/imx-hdmi.c b/drivers/staging/imx-drm/imx-hdmi.c
index cf21252..f557ea8 100644
--- a/drivers/staging/imx-drm/imx-hdmi.c
+++ b/drivers/staging/imx-drm/imx-hdmi.c
@@ -159,6 +159,7 @@ static inline u8 hdmi_readb(struct imx_hdmi *hdmi, int offset)
 static void hdmi_modb(struct imx_hdmi *hdmi, u8 data, u8 mask, unsigned reg)
 {
 	u8 val = hdmi_readb(hdmi, reg) & ~mask;
+
 	val |= data & mask;
 	hdmi_writeb(hdmi, val, reg);
 }
@@ -659,8 +660,8 @@ static inline void hdmi_phy_test_dout(struct imx_hdmi *hdmi,
 
 static bool hdmi_phy_wait_i2c_done(struct imx_hdmi *hdmi, int msec)
 {
-	unsigned char val = 0;
-	val = hdmi_readb(hdmi, HDMI_IH_I2CMPHY_STAT0) & 0x3;
+	unsigned char val = hdmi_readb(hdmi, HDMI_IH_I2CMPHY_STAT0) & 0x3;
+
 	while (!val) {
 		udelay(1000);
 		if (msec-- == 0)
-- 
1.8.3.2



More information about the devel mailing list