[PATCH 06/06] staging: dgap: fix checkpatch warning about adding typedefs

Mark Hounschell markh at compro.net
Thu Apr 3 11:51:51 UTC 2014


On 04/03/2014 04:56 AM, Dan Carpenter wrote:
> On Tue, Mar 25, 2014 at 04:38:18PM -0400, Mark Hounschell wrote:
>> This patch fixes a checkpatch warning about adding typedefs
>> in dgap.h
>>
>> Signed-off-by: Mark Hounschell <markh at compro.net>
>> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
>> ---
>>   drivers/staging/dgap/dgap.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/dgap/dgap.h b/drivers/staging/dgap/dgap.h
>> index 2fce41c..e9ba2a4 100644
>> --- a/drivers/staging/dgap/dgap.h
>> +++ b/drivers/staging/dgap/dgap.h
>> @@ -40,7 +40,7 @@
>>   #endif
>>
>>   /* Required for our shared headers! */
>> -typedef unsigned char		uchar;
>> +#define uchar unsigned char
>>
>
> That's not the point of the warning.  Just replace all the instances of
> uchar with u8.
>

OK, I'll send a patch for this.

Mark



More information about the devel mailing list