[PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros
Greg KH
gregkh at linuxfoundation.org
Tue Apr 1 16:33:00 UTC 2014
On Tue, Apr 01, 2014 at 09:52:11AM -0300, Guido Martínez wrote:
> Parenthesize both macros so they will not break program logic if used
> within another 'if'. Also fix a usage of DBG_PRT with a missing
> semicolon.
>
> Signed-off-by: Guido Martínez <guido at vanguardiasur.com.ar>
> ---
> drivers/staging/vt6655/device.h | 4 ++--
> drivers/staging/vt6655/wpactl.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index 062c3a3..483b017 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -148,8 +148,8 @@
>
> /*--------------------- Export Types ------------------------------*/
>
> -#define DBG_PRT(l, p, args...) { if (l <= msglevel) printk(p, ##args); }
> -#define PRINT_K(p, args...) { if (PRIVATE_Message) printk(p, ##args); }
> +#define DBG_PRT(l, p, args...) ({ if (l <= msglevel) printk(p, ##args); })
> +#define PRINT_K(p, args...) ({ if (PRIVATE_Message) printk(p, ##args); })
I would much rather see these "fixed" by removing them entirely and
using the in-kernel calls instead (netdev_* and dev_* where applicable.)
thanks,
greg k-h
More information about the devel
mailing list