[PATCHv2] staging: dwc2: Fix code that gets the nummber of host channels

Dan Carpenter dan.carpenter at oracle.com
Mon Sep 30 22:25:16 UTC 2013


On Mon, Sep 30, 2013 at 05:05:23PM -0500, dinguyen at altera.com wrote:
> From: Dinh Nguyen <dinguyen at altera.com>
> 
> The variable host_channels of dwc2_hw_params struct is only 4-bits. Adding
> a 1 to a 0xf results in a 0 for host_channels. Thus, the driver was always
> thinking it had 0 host channels.
> 
> Represent the correct number of host channels by using the host_channels
> variable of dwc2_core_params struct. We should do the +1 in
> dwc2_set_param_host_channels();
> 
> Signed-off-by: Dinh Nguyen <dinguyen at altera.com>

Ah.  Good.  You've fixed the compile problem, but I still don't think
you have tested it; there just wasn't enough time.

regards,
dan carpenter



More information about the devel mailing list