[PATCH 00/19] staging: comedi: pcl726: cleanup driver

[Hartley Sweeten]

On Thursday, September 26, 2013 2:45 AM, Ian Abbott wrote:
> On 2013-09-25 23:34, H Hartley Sweeten wrote:
>> Cleanup another comedi driver.
>>
>> Add support for the external interrupt on the ACL-6126 board.
>>
>> H Hartley Sweeten (19):
>>    staging: comedi: pcl726: convert boardinfo declaration to C99 format
>>    staging: comedi: core: introduce comedi_chan_range_is_{bi,uni}polar()
>>    staging: comedi: pcl726: remove 'bipolar' from the private data
>>    staging: comedi: pcl726: tidy up pcl726_ao_insn()
>>    staging: comedi: pcl726: tidy up pcl726_ao_insn_read()
>>    staging: comedi: pcl726: remove all '= 0' boardinfo
>>    staging: comedi: pcl726: enable the interrupt support code
>>    staging: comedi: pcl726: fix the analog output range_table_list initialization
>>    staging: comedi: pcl726: tidy up pcl726_attach()
>>    staging: comedi: pcl726: remove digital i/o register offsets from boardinfo
>>    staging: comedi: pcl726: tidy up the comedi_lrange code
>>    staging: comedi: pcl726: rename boardinfo 'IRQbits'
>>    staging: comedi: pcl726: remove unnecessary comments in boardinfo definition
>>    staging: comedi: pcl726: remove the *_SIZE defines
>>    staging: comedi: pcl726: final tidy up of boardinfo
>>    staging: comedi: pcl726: add support for the external interrupt signal
>>    staging: comedi: pcl726: tidy up multi-line comments
>>    staging: comedi: pcl726: update MODULE_DESCRIPTION
>>    staging: comedi: pcl726: rename 'boardtypes'
>>
>>   drivers/staging/comedi/comedidev.h      |  14 +
>>   drivers/staging/comedi/drivers/pcl726.c | 581 +++++++++++++++++++-------------
>>   2 files changed, 359 insertions(+), 236 deletions(-)
>
> Looks okay.  The various identifiers prefixed with "pcl818_" (patches 07 
> and 16) seems a poor choice though.

I was trying to make it obvious that the interrupt support was really just for
the ACL-6126 board. I'm not sure why I ended up prefixing them with pcl818_.
I blame my daughters... they are both currently sick.

They should just be prefixed with pcl726_ to match the namespace of the
rest of the driver. I can either rebase this series to fix it or post a new patch
after Greg applies these.

> Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

Thanks,
Hartley