[PATCH 00/31] staging: comedi: pcl711: cleanup driver

[Ian Abbott]

On 2013-09-23 17:38, Hartley Sweeten wrote:
> On Monday, September 23, 2013 9:23 AM, Ian Abbott wrote:
>> I can take a look at the async command support once this series has been
>> committed if you like.  Basically, comedi_buf_put() can be used in the
>> interrupt handler to write the sample to the comedi buffer.  If it
>> returns 0 (unsuccessful), the interrupt routine should set the
>> COMEDI_CB_OVERFLOW event flag (it can also set COMEDI_CB_ERROR, but that
>> is already set by comedi_buf_put()).  If comedi_buf_put() returns 1
>> (successful), then since the "scan length" is always 1 (a single sample)
>> in this driver, it can set the COMEDI_CB_EOS event flag.
>> pcl711_ai_cmd() should set devpriv->ntrig to the number of scans (or the
>> number of conversions) if cmd->stop_src == TRIG_COUNT.  The interrupt
>> handler should only decrement devpriv->ntrig if s->async->cmd.stop_src
>> == TRIG_COUNT.  (Also, devpriv->ntrig should be an unsigned int.)
>
> I'm hoping this series, and the adl_pci6208 cleanup, get applied by Greg before
> Stephen Rothwell freezes linux-next on Friday. Once this is in if you can fix up
> the command support that would be great!

I've already done it, but don't want to confuse Greg by submitting 
patches against the results of yet-to-be-applied patches!  (Hartley, if 
you want to review them in advance, let me know and I'll send them to 
you privately.  There are only 3 patches.)

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-