[PATCH 3/4] staging: et131x: Whitespace changes, cat some spilt lines

Dan Carpenter dan.carpenter at oracle.com
Wed Sep 11 12:46:33 UTC 2013


On Wed, Sep 11, 2013 at 01:29:49PM +0100, Mark Einon wrote:
> On Wed, Sep 04, 2013 at 12:19:16PM +0300, Dan Carpenter wrote:
> > Sorry, this is still in my postponed messages folder.  I meant to send
> > it earlier.
> > 
> > On Mon, Sep 02, 2013 at 10:23:21PM +0100, Mark Einon wrote:
> > > Ignoring checkpatch for some lines - now just over 80 chars, but much
> > > more readable.
> > > 
> > 
> > The person who "fixed" these long lines, did it in the wrong way, yes.
> > But we always apply those because it's the easiest way and you can't
> > fight against checkpatch.pl.  If we go back to long lines, we'll just
> > immediately apply another "break the long lines up" patch from some
> > newbie who doesn't know any better.
> > 
> > We need to fix it in the right way instead of re-introducing checkpatch
> > warnings.
> 
> ** Greg ** - please drop this patchset, I will re-send the other three
> without this one.
> 

The other patches can apply without this one although the line
numbers are shifted for [PATCH 4/4 v2].

regards,
dan carpenter



More information about the devel mailing list