[PATCH] staging: xillybus: fix format string usage

Kees Cook keescook at chromium.org
Wed Sep 11 04:38:04 UTC 2013


Makes sure format string cannot leak into device_create() call.

Signed-off-by: Kees Cook <keescook at chromium.org>
---
 drivers/staging/xillybus/xillybus_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/xillybus/xillybus_core.c b/drivers/staging/xillybus/xillybus_core.c
index efc5698..7db6f03 100644
--- a/drivers/staging/xillybus/xillybus_core.c
+++ b/drivers/staging/xillybus/xillybus_core.c
@@ -2054,7 +2054,7 @@ static int xillybus_init_chrdev(struct xilly_endpoint *endpoint,
 				       NULL,
 				       MKDEV(major, i),
 				       NULL,
-				       devname);
+				       "%s", devname);
 
 		if (IS_ERR(device)) {
 			pr_warn("xillybus: Failed to create %s "
-- 
1.7.9.5


-- 
Kees Cook
Chrome OS Security


More information about the devel mailing list