[PATCH v3] mfd: rtsx: Modify rts5249_optimize_phy

wwang wei_wang at realsil.com.cn
Tue Sep 10 09:58:18 UTC 2013


于 2013年09月10日 17:28, Lee Jones 写道:
> I would like some more information in the commit log though. You're
> making a lot of configuration changes here and due to the
> incomprehensible 'magic numbers' used previously, it's impossible to
> know what you're changing by just reading the code.
>
> Why won't the rts**** be initialise properly and what exactly are you
> changing to rectify the situation?

Hi Lee:

It's a little difficult to describe it very clearly. To put it simply, 
the default setting of rts5249 is not good, and it will cause the signal 
quality very bad. So we have to change those values to achieve a better 
signal quality.

Do I need amend the commit and add the above description and resend it ?

BR,
Wei


More information about the devel mailing list