[PATCH 2/4] [media] lirc_bt829: Fix physical address type

Ben Hutchings ben at decadent.org.uk
Mon Sep 2 01:41:19 UTC 2013


On Sun, 2013-09-01 at 22:37 -0300, Fabio Estevam wrote:
> On Sun, Sep 1, 2013 at 9:39 PM, Ben Hutchings <ben at decadent.org.uk> wrote:
> 
> >         pci_addr_phys = pdev->resource[0].start;
> > -       dev_info(&pdev->dev, "memory at 0x%08X\n",
> > -                (unsigned int)pci_addr_phys);
> > +       dev_info(&pdev->dev, "memory at 0x%08llX\n",
> > +                (unsigned long long)pci_addr_phys);
> 
> You could use %pa instead for printing phys_addr_t:
> 
> dev_info(&pdev->dev, "memory at %pa\n", &pci_addr_phys);

Could do, but I'm not sure it's clearer.  And all these %p formats
defeat type-checking anyway.

Ben.

-- 
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20130902/51d58536/attachment.asc>


More information about the devel mailing list