[PATCH] staging: octeon: drop redundant mac address check
David Daney
ddaney at caviumnetworks.com
Tue Oct 29 19:15:37 UTC 2013
On 10/28/2013 06:24 PM, Luka Perkov wrote:
> Checking if MAC address is valid using is_valid_ether_addr() is already done in
> of_get_mac_address().
>
> Signed-off-by: Luka Perkov <luka at openwrt.org>
Acked-by: David Daney <david.daney at cavium.com>
> ---
> drivers/staging/octeon/ethernet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index c3a90e7..10300da 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -453,7 +453,7 @@ int cvm_oct_common_init(struct net_device *dev)
> if (priv->of_node)
> mac = of_get_mac_address(priv->of_node);
>
> - if (mac && is_valid_ether_addr(mac))
> + if (mac)
> memcpy(dev->dev_addr, mac, ETH_ALEN);
> else
> eth_hw_addr_random(dev);
>
More information about the devel
mailing list