[OPW kernel] Re: [PATCH v2] Staging: zram: Fix variable dereferenced before check

Greg KH gregkh at linuxfoundation.org
Mon Oct 21 03:52:08 UTC 2013


On Sun, Oct 20, 2013 at 01:33:39PM +0100, Josh Triplett wrote:
> On Sat, Oct 19, 2013 at 01:59:05PM -0700, Greg KH wrote:
> > On Sat, Oct 19, 2013 at 10:01:42PM +0530, Rashika Kheria wrote:
> > > This patch fixes the following Smatch warning in zram_drv.c-
> > > ~/git/kernels/linux/drivers/staging/zram/zram_drv.c:663
> > > reset_store() warn: variable dereferenced before check 'bdev' (see line 652)
> > > ~/git/kernels/linux/drivers/staging/zram/zram_drv.c:899
> > > destroy_device() warn: variable dereferenced before check 'zram->disk' (see line 896)
> > > 
> > > Signed-off-by: Rashika Kheria <rashika.kheria at gmail.com>
> > 
> > zram is messy, tricky, and I hate it.  Seriously, I which I had never
> > taken it into the staging tree...
> > 
> > Anyway, I want the existing zram developers/maintainers to review this
> > patch before I can accept it, as I don't trust anything that is ever
> > done in that code, especially as I don't test it :)
> > 
> > Minchan, Jiang, Nitin, what do you think of the patch below?  Can I get
> > your ack on it so that I can apply it?
> 
> I think you actually want to review v3 of this patch, not v2.

Ah, good point.  Rashika, can you use the scripts/get_maintainer.pl tool
on your v3 patch and resend it to everyone it says to send it to, for
wider review?

thanks,

greg k-h


More information about the devel mailing list