[PATCH 06/35] staging: comedi: adl_pci9118: sample types are unsigned

[Ian Abbott]

On 18/10/13 18:24, Hartley Sweeten wrote:
> On Wednesday, October 16, 2013 6:40 AM, Ian Abbott wrote:
>> Sample values in comedi are generally represented as unsigned values.
>> Change the `ao_data[]` and `dmabuf_virt[]` members of `struct
>> pci9118_private` and various local variables dealing with sample values
>> to use `unsigned short` instead of `short` for consistency.
>>
>> Also remove the `short *ai_data` member of `struct pci9118_private` as
>> it is only assigned to.
>>
>> Signed-off-by: Ian Abbott <abbotti at mev.co.uk>
>> ---
>>   drivers/staging/comedi/drivers/adl_pci9118.c | 18 ++++++++----------
>>   1 file changed, 8 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
>> index bd5c8bb..0f2e859 100644
>> --- a/drivers/staging/comedi/drivers/adl_pci9118.c
>> +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
>> @@ -352,12 +352,11 @@ struct pci9118_private {
>>   						 * on external start
>>   						 */
>>   	unsigned int ai_data_len;
>> -	short *ai_data;
>> -	short ao_data[2];			/* data output buffer */
>> +	unsigned short ao_data[2];		/* data output buffer */
>>   	unsigned int ai_scans;			/* number of scans to do */
>>   	char dma_doublebuf;			/* we can use double buffering */
>>   	unsigned int dma_actbuf;		/* which buffer is used now */
>> -	short *dmabuf_virt[2];			/*
>> +	unsigned short *dmabuf_virt[2];			/*
>
> Nit. Comment alignment is off.

So it is!  I'll post a follow-up later.