[PATCH 06/35] staging: comedi: adl_pci9118: sample types are unsigned

Ian Abbott abbotti at mev.co.uk
Sat Oct 19 23:27:35 UTC 2013


On 18/10/13 18:00, Hartley Sweeten wrote:
> On Wednesday, October 16, 2013 6:40 AM, Ian Abbott wrote:
>> Sample values in comedi are generally represented as unsigned values.
>> Change the `ao_data[]` and `dmabuf_virt[]` members of `struct
>> pci9118_private` and various local variables dealing with sample values
>> to use `unsigned short` instead of `short` for consistency.
>>
>> Also remove the `short *ai_data` member of `struct pci9118_private` as
>> it is only assigned to.
>>
>> Signed-off-by: Ian Abbott <abbotti at mev.co.uk>
>> ---
>>   drivers/staging/comedi/drivers/adl_pci9118.c | 18 ++++++++----------
>>   1 file changed, 8 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
>> index bd5c8bb..0f2e859 100644
>> --- a/drivers/staging/comedi/drivers/adl_pci9118.c
>> +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
>
> [snip]
>
>> @@ -1987,8 +1985,8 @@ static int pci9118_common_attach(struct comedi_device *dev, int disable_irq,
>>   		for (i = 0; i < 2; i++) {
>>   			for (pages = 4; pages >= 0; pages--) {
>>   				devpriv->dmabuf_virt[i] =
>> -				    (short *)__get_free_pages(GFP_KERNEL,
>> -							      pages);
>> +				    (unsigned short *)
>> +				    __get_free_pages(GFP_KERNEL, pages);
>
> Nit. Is the cast really needed?

Yes, because __get_free_pages() returns unsigned long, not a void *.



More information about the devel mailing list