[PATCH v2] staging: lustre: libcfs: Remove new typedef in bitmap.h

Greg KH gregkh at linuxfoundation.org
Sat Oct 19 21:15:00 UTC 2013


On Sat, Oct 19, 2013 at 02:06:42PM -0700, Lisa Nguyen wrote:
> Fix cfs_bitmap struct, function parameters, and variable
> declarations to eliminate the "Do not add new typedefs"
> warning generated by checkpatch.pl and meet kernel coding
> style.
> 
> Signed-off-by: Lisa Nguyen <lisa at xenapiadmin.com>
> ---
> 
> Changes since v2:
> - Original patch had struct cfs_bitmap_t. Struct is renamed to
> cfs_bitmap, following the Linux naming convention.
> 
>  drivers/staging/lustre/include/linux/libcfs/bitmap.h | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/lustre/include/linux/libcfs/bitmap.h b/drivers/staging/lustre/include/linux/libcfs/bitmap.h
> index d1538b0..7cf912e 100644
> --- a/drivers/staging/lustre/include/linux/libcfs/bitmap.h
> +++ b/drivers/staging/lustre/include/linux/libcfs/bitmap.h
> @@ -37,18 +37,18 @@
>  #define _LIBCFS_BITMAP_H_
>  
>  
> -struct cfs_bitmap_t {
> +struct cfs_bitmap {

This patch was made on top of your previous patch, but as I didn't apply
your previous patch, I can't take this one either :(

Please mush[1] them together into one patch, that only does the correct
thing here, so that I can apply it.

thanks,

greg k-h

[1] Yeah, lovely technical term, I know, I don't know what else to call
    it...


More information about the devel mailing list