[PATCH 3/9 RESENT] staging: r8188eu: Fix sparse warnings in ioctl_linux.c

Ben Hutchings bhutchings at solarflare.com
Fri Oct 18 22:08:31 UTC 2013


On Fri, 2013-10-18 at 16:34 -0500, Larry Finger wrote:
> Sparse checking results in the following warnings:
> 
>    CHECK   drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3932:17: warning: cast removes 
> address space of expression
> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3933:31: warning: incorrect type 
> in argument 1 (different address spaces)
[...]
> -		DBG_88E("[%s] extra = %s\n", __func__, (char *)wrqu->data.pointer);
> -	if (!memcmp(wrqu->data.pointer, "status", 6)) {
> +		DBG_88E("[%s] extra = %s\n", __func__, (__force char *)wrqu->data.pointer);
> +	if (!memcmp((__force const char *)wrqu->data.pointer, "status", 6)) {
[...]

This is hiding the problem, not fixing it.

This private interface needs to be removed anyway.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.



More information about the devel mailing list