[PATCH] staging: dwc2: Make dwc2_hw_params.host_channels large enough

Matthijs Kooijman matthijs at stdin.nl
Thu Oct 3 07:34:45 UTC 2013


Hi Paul,

> By the way, it looks like 'num_dev_ep' would have the same problem,
I don't think so, since the hardware doesn't do the off-by-one trick
there (presumably because having 0 endpoints make sense, but 0 host
channels doesn't):

        hw->num_dev_ep = (hwcfg2 & GHWCFG2_NUM_DEV_EP_MASK) >>
                         GHWCFG2_NUM_DEV_EP_SHIFT;

> except it is not used because we don't support device mode yet.
> That one and also 'num_dev_perio_in_ep' and 'dev_token_q_depth' should
> be removed, I think.
Doesn't hurt to keep them around, I think? When device mode is
implemented, I guess this code will need to present exactly like it is
now (unlike other device mode code, which likely needs to be adapted to
whatever s3-hsotg is doing now)?

Gr.

Matthijs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20131003/2095e999/attachment.asc>


More information about the devel mailing list