[PATCH] staging: silicom: remove dead code

Michal Nazarewicz mpn at google.com
Fri Nov 29 17:05:01 UTC 2013

From: Michal Nazarewicz <mina86 at mina86.com>

bus_info field of struct ethtool_drvinfo is an array thus it always
evaluates to true in a boolean context.  Therefore operation
depending on it being false will never be executed.

Signed-off-by: Michal Nazarewicz <mina86 at mina86.com>
 drivers/staging/silicom/bpctl_mod.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
index 39dc92a..20325f5 100644
--- a/drivers/staging/silicom/bpctl_mod.c
+++ b/drivers/staging/silicom/bpctl_mod.c
@@ -135,8 +135,6 @@ static int bp_get_dev_idx_bsf(struct net_device *dev, int *index)
 		return -EOPNOTSUPP;
-	if (!drvinfo.bus_info)
-		return -ENODATA;
 	if (!strcmp(drvinfo.bus_info, "N/A"))
 		return -ENODATA;

More information about the devel mailing list