[PATCH 15/39] staging: comedi: comedi_fops: remove use of DPRINTK

Greg KH gregkh at linuxfoundation.org
Mon Nov 25 20:21:25 UTC 2013


On Mon, Nov 25, 2013 at 08:16:32PM +0000, Hartley Sweeten wrote:
> On Monday, November 25, 2013 12:54 PM, Greg KH wrote:
> > On Fri, Nov 22, 2013 at 10:47:40AM -0700, H Hartley Sweeten wrote:
> >> Use dev_dbg(), or pr_debug() when dev is not valid, instead of the
> >> DPRINTK macro to output the comedi debugging information.
> >> 
> >> Remove the debug messages for allocation failures. The failure will
> >> have already generated a message.
> >> 
> >> Reword the messages that include the dev->minor number. This number
> >> will already be displayed as part of the dev_dbg() output.
> >> 
> >> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> >
> > This patch fails in my tree, so I think we are out of sync, and I'm
> > getting tired of unline-wrapping these patches by hand :(
> 
> Sorry about that. I was hoping next-20131121 was in sync with your tree.
> 
> Do all the patches have line wrapping problems? We had a server crash
> and I had to rebuild by linux virtual machine.

Yes, I think all of them with long lines were wrapped.  If you use 'git
send-email' that shouldn't be an issue.

thanks,

greg k-h


More information about the devel mailing list