[PATCH 15/39] staging: comedi: comedi_fops: remove use of DPRINTK

Hartley Sweeten HartleyS at visionengravers.com
Mon Nov 25 20:16:32 UTC 2013


On Monday, November 25, 2013 12:54 PM, Greg KH wrote:
> On Fri, Nov 22, 2013 at 10:47:40AM -0700, H Hartley Sweeten wrote:
>> Use dev_dbg(), or pr_debug() when dev is not valid, instead of the
>> DPRINTK macro to output the comedi debugging information.
>> 
>> Remove the debug messages for allocation failures. The failure will
>> have already generated a message.
>> 
>> Reword the messages that include the dev->minor number. This number
>> will already be displayed as part of the dev_dbg() output.
>> 
>> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
>
> This patch fails in my tree, so I think we are out of sync, and I'm
> getting tired of unline-wrapping these patches by hand :(

Sorry about that. I was hoping next-20131121 was in sync with your tree.

Do all the patches have line wrapping problems? We had a server crash
and I had to rebuild by linux virtual machine.

> So, can you redo this series on my staging-next branch from this place
> in the series, and add Ian's Reviewed-by and resend?

Will do. I will redo the ones from 15 on and repost them. Hopefully I can
get them out today.

Regards,
Hartley


More information about the devel mailing list