[PATCH] Staging: comedi: fix coding style issues in unioxx5.c
gregkh at linuxfoundation.org
Tue Nov 12 00:15:40 UTC 2013
On Fri, Nov 01, 2013 at 06:01:56PM +0530, Conrad Gomes wrote:
> This is a patch which fixes coding style issues in unioxx5.c found
> by checkpatch.pl
> 1) Replaced printk with pr_info and pr_err
Drivers should never call printk() as they all have access to a struct
device somewhere. So please call dev_info() or dev_err() instead.
> 2) Reinitialized n_subd before for loop to fix over 80 character
> 3) Reworded comment to fix 80 character warning
Patches should do one thing, not 3 things. Care to break this up into
"one logical change per patch"? Yes, it's a small thing, but if you had
done this already, I could have taken the other 2 patches and you would
have just had to redo one patch in this series...
More information about the devel