[patch] Staging: sb105x: info leak in mp_get_count()

Steven Rostedt rostedt at goodmis.org
Mon Nov 4 17:08:50 UTC 2013


On Mon, 4 Nov 2013 02:11:50 +0300
Dan Carpenter <dan.carpenter at oracle.com> wrote:

> On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote:
> > On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote:
> > > The icount.reserved[] array isn't initialized so it leaks stack
> > > information to userspace.
> > > 
> > > Reported-by: Nico Golde <nico at ngolde.de>
> > > Reported-by: Fabian Yamaguchi <fabs at goesec.de>
> > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> > 
> > Reviewed-by: Josh Triplett <josh at joshtriplett.org>
> > 
> > Also, you don't quite have the patch format right here; you should have
> > a --- line after the commit mesage, followed by a diffstat.  Did you use
> > git format-patch to generate this patch?
> 
> I normally don't include the diffstat.  Which tools care about that?
> 

As Josh already replied, it is most helpful for the human reviewer.
Linus uses it all the time to see how intrusive a patch may be.

Yes, please always include a diffstat for any patch you send.

Thanks,

-- Steve


More information about the devel mailing list