[patch] Staging: sb105x: info leak in mp_get_count()

Dan Carpenter dan.carpenter at oracle.com
Sun Nov 3 23:11:50 UTC 2013


On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote:
> On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote:
> > The icount.reserved[] array isn't initialized so it leaks stack
> > information to userspace.
> > 
> > Reported-by: Nico Golde <nico at ngolde.de>
> > Reported-by: Fabian Yamaguchi <fabs at goesec.de>
> > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> 
> Reviewed-by: Josh Triplett <josh at joshtriplett.org>
> 
> Also, you don't quite have the patch format right here; you should have
> a --- line after the commit mesage, followed by a diffstat.  Did you use
> git format-patch to generate this patch?

I normally don't include the diffstat.  Which tools care about that?

regards,
dan carpenter



More information about the devel mailing list