[PATCH 2/4] ozwpan: replace alloc_skb with dev_alloc_skb in ozproto.c

Xenia Ragiadakou burzalodowa at gmail.com
Thu May 23 21:57:17 UTC 2013


On 05/24/2013 12:18 AM, Dan Carpenter wrote:
> [snip]
> I don't know much about networking.  The problems with this patch
> are:
>
> 1) No reason to apply it in the changelog.
> 2) The kfree_skb() wasn't updated to match.  After sending my email
>     I saw that you fixed this in a later patch and I sent a grumpier
>     than necessary email.  Sorry.  Splitting that up into two patches
>     breaks git bisect so it's not allowed.  Anyways, it's a newbie
>     mistake.  No worries again.
> 3) The comments on dev_alloc_skb() say it's obsolete and we should
>     use netdev_alloc_skb() instead.
>
> I don't actually know when it's appropriate to use one or the other
> honestly...  It could be that you're right about this here.  I
> honestly don't know, so that's why it has to be explained to me in
> the changelog.
>
> regards,
> dan carpenter

You are right, since there is a net_device pointer in the function
there is no reason not to put netdev_alloc_skb().
I will fix this patch and i will try to justify it in changelog (as much as
my comprehension and my english permit it).
Also i will make all the changes in one patch, since i should not
separate function pairs I agree.

And the next time i hope that i won't be so light minded when
replacing code (i hope) ;)

Thanks,
Ksenia



More information about the devel mailing list