DSP Bridge driver DVFS: two Kconfig oddities

Paul Bolle pebolle at tiscali.nl
Tue May 14 20:28:31 UTC 2013


0) I ran into two Kconfig oddities with the Dynamic Voltage and
Frequency Scaling (DVFS) option for the DSP Bridge driver (ie, Kconfig
symbol TIDSPBRIDGE_DVFS).

1) That Kconfig symbol depends on OMAP_PM_SRF. But OMAP_PM_SRF doesn't
exist in mainline. It seems it actually has never been part of mainline.
(Currently, the only related symbol seems to be OMAP_PM_NOOP.) So the
DVFS code in mainline has not been buildable ever since it got added in
v2.6.36. What is the reason for this dependency on OMAP_PM_SRF?

2) TIDSPBRIDGE_DVFS also depends on CPU_FREQ. But in the code we see:
    drivers/staging/tidspbridge/rmgr/node.c:1119:#if defined(CONFIG_TIDSPBRIDGE_DVFS) && !defined(CONFIG_CPU_FREQ)
    drivers/staging/tidspbridge/rmgr/node.c:1170:#if defined(CONFIG_TIDSPBRIDGE_DVFS) && !defined(CONFIG_CPU_FREQ)
    drivers/staging/tidspbridge/rmgr/node.c:1188:#if defined(CONFIG_TIDSPBRIDGE_DVFS) && !defined(CONFIG_CPU_FREQ)
    drivers/staging/tidspbridge/rmgr/proc.c:1025:#if defined(CONFIG_TIDSPBRIDGE_DVFS) && !defined(CONFIG_CPU_FREQ)
    drivers/staging/tidspbridge/rmgr/proc.c:1155:#if defined(CONFIG_TIDSPBRIDGE_DVFS) && !defined(CONFIG_CPU_FREQ)
    drivers/staging/tidspbridge/rmgr/proc.c:1173:#if defined(CONFIG_TIDSPBRIDGE_DVFS) && !defined(CONFIG_CPU_FREQ)

So either this dependency is incorrect or the node.c and prog.c code
needs some cleaning up. Which is it?


Paul Bolle




More information about the devel mailing list