[RFC PATCH 20/30] staging: comedi: dt9812: factor the device reset out of dt9812_probe()

Ian Abbott abbotti at mev.co.uk
Tue May 7 13:21:28 UTC 2013


On 2013-05-03 21:50, H Hartley Sweeten wrote:
> When this driver is converted to the comedi (*auto_attach) mechanism
> the device reset will be done during the (*auto_attach). To make the
> conversion cleaner, factor the device reset out of the (*probe).
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfonudation.org>
> ---
>   drivers/staging/comedi/drivers/dt9812.c | 111 +++++++++++++++++++-------------
>   1 file changed, 65 insertions(+), 46 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt9812.c b/drivers/staging/comedi/drivers/dt9812.c
> index 42a4a9d..cf8f10f 100644
> --- a/drivers/staging/comedi/drivers/dt9812.c
> +++ b/drivers/staging/comedi/drivers/dt9812.c
> @@ -774,6 +774,69 @@ static int dt9812_find_endpoints(struct usb_interface *intf,
>   	return 0;
>   }
>
> +static int rt9812_reset_device(struct usb_interface *intf,
> +			       struct usb_dt9812 *devpriv)

Shouldn't that be called dt9812_reset_device?

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-



More information about the devel mailing list