[PATCH] Staging: Panel: panel: Fixed checkpatch line length warnings

Dan Carpenter dan.carpenter at oracle.com
Sun May 5 13:06:40 UTC 2013


On Sat, May 04, 2013 at 11:21:17AM -0400, Jake Champlin wrote:
> @@ -1802,10 +1803,11 @@ static inline void input_state_falling(struct logical_input *input)
>  
>  			if (input->u.kbd.repeat_str[0]) {
>  				char *repeat_str = input->u.kbd.repeat_str;
> -				if (input->high_timer >= KEYPAD_REP_START)
> +				if (input->high_timer >= KEYPAD_REP_START) {
> +					int s = sizeof(input->u.kbd.repeat_str);
>  					input->high_timer -= KEYPAD_REP_DELAY;
> -					keypad_send_key(repeat_str,
> -							sizeof(input->u.kbd.repeat_str));
> +					keypad_send_key(repeat_str, s);
> +				}


This looks like a bugfix.  Good job.  Please mention bug fixes in
the changelog next time.

regards,
dan carpenter





More information about the devel mailing list