[RFC PATCH 00/39] staging: comedi: usbduxfast: cleanup driver
Ian Abbott
abbotti at mev.co.uk
Fri May 3 10:21:52 UTC 2013
On 2013-05-01 23:15, H Hartley Sweeten wrote:
> Since the merge window is now open, this series is posted as an RFC.
> Any comments would be appreciated. I'm hoping to get any issues
> addressed so the series will be ready when the staging tree is
> opened after the merge window closes.
>
> Currently this driver uses a static array to pass the usb_interface
> from the usb_driver to the comedi_driver. This puts a limitation on
> the number of USB devices that can be connected and it makes the
> USB (*probe) -> comedi (*auto_attach) and comedi (*detach) -> USB
> (*disconnect) process overly complicated.
>
> By pushing all the USB (*probe) functionality into the comedi (*auto_attach)
> and the USB (*disconnect) into the comedi (*detach), the USB device
> limitation is removed since the private data can be kzalloc'ed. We can
> also remove the static array as well as the semaphore that protected it.
>
> The rest of this series just removes any unnecessary cruft in
> the driver and cleans up the rest of the driver.
I only had time to skim over the individual patches, so am concentrating
on the final result of applying the series of patches.
It looks fine to me, and a lot simpler. I suppose haters are gonna hate
the transition from asynchronous firmware loading to synchronous
firmware loading.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti at mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
More information about the devel
mailing list