[PATCH 10/22] staging: comedi: s626: remove MC_DISABLE macro

Ian Abbott abbotti at mev.co.uk
Tue Mar 26 20:36:32 UTC 2013


On 26/03/2013 20:34, Ian Abbott wrote:
> On 26/03/2013 18:38, H Hartley Sweeten wrote:
>> On Monday, March 25, 2013 11:46 AM, Greg Kroah-Hartman wrote:
>>> On Fri, Mar 22, 2013 at 03:57:40PM -0700, H Hartley Sweeten wrote:
>>>> This macro relies on a local variable having a specific name. Replace
>>>> it with a new helper function, s626_mc_disable().
>>>>
>>>> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
>>>> Cc: Ian Abbott <abbotti at mev.co.uk>
>>>> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
>>>> ---
>>>>    drivers/staging/comedi/drivers/s626.c | 20 +++++++++++++-------
>>>>    1 file changed, 13 insertions(+), 7 deletions(-)
>>>
>>> I've applied this series up to, and including, this one, care to resend
>>> the rest after fixing the problems that Dan pointed out?
>>
>> Greg,
>>
>> I just posted the updated series with the issues addressed.
>>
>> [PATCH 00/12] staging: comedi: s626: cleanup driver part 2
>
> But patch 04 won't do the right thing.

I mean patch 05 ("remove the uint16_t casts of the bit values") won't do 
the right thing.  Patch 04 is fine.  Sorry!

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-



More information about the devel mailing list