[PATCH -next] [media] go7007: fix invalid use of sizeof in go7007_usb_i2c_master_xfer()
Dan Carpenter
dan.carpenter at oracle.com
Tue Mar 26 07:04:15 UTC 2013
On Tue, Mar 26, 2013 at 02:42:47PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>
> sizeof() when applied to a pointer typed expression gives the
> size of the pointer, not that of the pointed data.
>
This fix isn't right. "buf" is a char pointer. I don't know what
this code is doing. Instead of sizeof(*buf) it should be something
like "buflen", "msg[i].len", "msg[i].len + 1" or "msg[i].len + 3".
I'm not sure which is correct here or what it's doing, sorry.
regards,
dan carpenter
More information about the devel
mailing list