[PATCH 17/51 v2] staging: comedi: ni_labpc: introduce labpc_range_is_unipolar()

H Hartley Sweeten hartleys at visionengravers.com
Mon Mar 25 16:33:06 UTC 2013


On Monday, March 25, 2013 3:20 AM, Ian Abbott wrote:
> On 2013-03-22 16:42, H Hartley Sweeten wrote:
>> +static bool labpc_range_is_unipolar(struct comedi_subdevice *s,
>> +				    unsigned int range)
>> +{
>> +	const struct comedi_lrange *lrange = s->range_table;
>> +	const struct comedi_krange *krange = &lrange->range[range];
>> +
>> +	if (krange->min < 0)
>> +		return false;
>> +	else
>> +		return true;
>> +}
>
> That last bit could be simplified to:
>
>	return krange->min >= 0;
>
> but it doesn't really matter.

I like that better.

I need to check the other comedi drivers to see if this should maybe be
a generic "comedi_range_is_unipolar" helper in comedidev.h.

Regards,
Hartley





More information about the devel mailing list