[PATCH] staging: vme: fix for a potential NULL pointer dereference
Kumar Amit Mehta
gmate.amit at gmail.com
Mon Mar 25 05:37:48 UTC 2013
Audit the return value of cdev_alloc and hence fixes a potential NULL pointer
dereferencing.
Signed-off-by: Kumar Amit Mehta <gmate.amit at gmail.com>
---
drivers/staging/vme/devices/vme_user.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
index d074b1e..da7f759 100644
--- a/drivers/staging/vme/devices/vme_user.c
+++ b/drivers/staging/vme/devices/vme_user.c
@@ -710,6 +710,10 @@ static int vme_user_probe(struct vme_dev *vdev)
/* Register the driver as a char device */
vme_user_cdev = cdev_alloc();
+ if (!vme_user_cdev) {
+ err = -ENOMEM;
+ goto err_char;
+ }
vme_user_cdev->ops = &vme_user_fops;
vme_user_cdev->owner = THIS_MODULE;
err = cdev_add(vme_user_cdev, MKDEV(VME_MAJOR, 0), VME_DEVS);
--
1.7.9.5
More information about the devel
mailing list