[PATCH 00/22] staging: comedi: s626: cleanup driver
H Hartley Sweeten
hsweeten at visionengravers.com
Fri Mar 22 22:53:53 UTC 2013
Simplify the handling of the three digital i/o subdevices.
Split up the interrupt handler so it's easier to understand and
maintain.
Remove a number of macros that rely on having a local variable with
a "magic" name.
Remove a bunch of casts that were causing some sparse warnings.
Cleanup the digital i/o subdevice functions.
Tidy up the subdevice init in the attach function.
This driver still needs more cleanup but I need to locate a register
programming manual for it...
H Hartley Sweeten (22):
staging: comedi: s626: simplify dio register access
staging: comedi: s626: factor dio interrupt handling from s626_irq_handler()
staging: comedi: s626: cleanup "subdevice" and "cmd" in s626_irq_handler()
staging: comedi: s626: use a local var for the s->async in s626_irq_handler()
staging: comedi: s626: factor eos interrupt handling from s626_irq_handler()
staging: comedi: s626: factor counter interrupt handling from s626_irq_handler()
staging: comedi: s626: cleanup comedi_lrange table
staging: comedi: s626: #ifdef out a block of unused code
staging: comedi: s626: remove MC_ENABLE macro
staging: comedi: s626: remove MC_DISABLE macro
staging: comedi: s626: remove MC_TEST macro
staging: comedi: s626: remove WR7146 and SETVECT macros
staging: comedi: s626: remove RR7146 macro
staging: comedi: s626: rename private data 'base_addr' variable
staging: comedi: s626: remove the uint16_t casts of the bit values
staging: comedi: s626: cleanup s626_dio_insn_config()
staging: comedi: s626: cleanup s626_dio_insn_bits()
staging: comedi: s626: remove subdevice pointer math
staging: comedi: s626: cleanup subdevice init
staging: comedi: s626: remove the ai (*insn_config) function
staging: comedi: s626: async commands require an interrupt
staging: comedi: s626: remove the "interrupt call test"
drivers/staging/comedi/drivers/s626.c | 1193 ++++++++++++++++-----------------
drivers/staging/comedi/drivers/s626.h | 101 ++-
2 files changed, 602 insertions(+), 692 deletions(-)
--
1.8.1.4
More information about the devel
mailing list