[PATCH 13/26] staging: comedi: ni_labpc: split out bus specific code

[H Hartley Sweeten]

On Thursday, March 21, 2013 4:17 AM, Ian Abbott wrote:
> On 2013-03-20 15:54, H Hartley Sweeten wrote:
>> On Wednesday, March 20, 2013 4:27 AM, Ian Abbott wrote:
>>> On 2013-03-20 01:06, H Hartley Sweeten wrote:
>>>> The PCMCIA support for the National Instruments Lab-PC DAQCard-1200
>>>> is already handled by a separate module, ni_labpc_cs. Split the bus
>>>> specific ISA and PCI code out of this driver and create two new
>>>> drivers, ni_labpc_isa and ni_labpc_pci. This allows the ni_labpc
>>>> module to be a standalone module with all the "common" code.
>>>
>>> This would break scripts that run "modprobe ni_labpc" to load the driver
>>> for the ISA cards.  I can't imagine it affects all that many people,
>>> although that's why I retained the name "amplc_dio200" for the ISA card
>>> portion when splitting that driver.
>>
>> I thought about that but couldn't think of a "clean" way to split the ISA
>> support out. Leaving the ISA code in ni_labpc.c and moving the common
>> code out to something like ni_labpc_common.c makes the patch a lot
>> larger and more difficult to review.
>>
>> How about taking the patches up to this one as they are now and then
>> renaming ni_labpc.c  -> ni_labpc_common.c and ni_labpc_isa.c -> ni_labpc.c
>> in the next patch in the series?
>
> I'm not sure how you send a "git mv" by email, so it would probably end 
> up as a mega-patch regardless.
>
> The breakage in user scripts probably isn't the end of the world though. 
>  Just another tweak some unlucky users may need to do after updating 
> their system.

For right now, I have dropped the pieces that split the ni_labpc driver.
There is enough cleanup needed to the driver to make this patch series
fairly large as-is.

After the cleanup patches are accepted I'll do a follow up that splits
the bus specific pieces out. Hopefully the git-mv will not be as bad.

Regards,
Hartley