[PATCH 13/26] staging: comedi: ni_labpc: split out bus specific code

Ian Abbott abbotti at mev.co.uk
Thu Mar 21 11:16:58 UTC 2013


On 2013-03-20 15:54, H Hartley Sweeten wrote:
> On Wednesday, March 20, 2013 4:27 AM, Ian Abbott wrote:
>> On 2013-03-20 01:06, H Hartley Sweeten wrote:
>>> The PCMCIA support for the National Instruments Lab-PC DAQCard-1200
>>> is already handled by a separate module, ni_labpc_cs. Split the bus
>>> specific ISA and PCI code out of this driver and create two new
>>> drivers, ni_labpc_isa and ni_labpc_pci. This allows the ni_labpc
>>> module to be a standalone module with all the "common" code.
>>
>> This would break scripts that run "modprobe ni_labpc" to load the driver
>> for the ISA cards.  I can't imagine it affects all that many people,
>> although that's why I retained the name "amplc_dio200" for the ISA card
>> portion when splitting that driver.
>
> I thought about that but couldn't think of a "clean" way to split the ISA
> support out. Leaving the ISA code in ni_labpc.c and moving the common
> code out to something like ni_labpc_common.c makes the patch a lot
> larger and more difficult to review.
>
> How about taking the patches up to this one as they are now and then
> renaming ni_labpc.c  -> ni_labpc_common.c and ni_labpc_isa.c -> ni_labpc.c
> in the next patch in the series?

I'm not sure how you send a "git mv" by email, so it would probably end 
up as a mega-patch regardless.

The breakage in user scripts probably isn't the end of the world though. 
  Just another tweak some unlucky users may need to do after updating 
their system.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-



More information about the devel mailing list