[PATCH 2/8] staging: omap-thermal: use spin_lock_irqsave inside IRQ handler
Dan Carpenter
dan.carpenter at oracle.com
Mon Mar 18 19:16:18 UTC 2013
On Mon, Mar 18, 2013 at 10:59:10AM -0400, Eduardo Valentin wrote:
> Even if the IRQ is not firing because it is ONE_SHOT and disable
> at INTC level, the IRQ handler must use spin_lock_irqsave.
> It is necessary to disable IRQs from the current
> CPU while it is holding a spin_lock which is need.
>
Gar... I think I was just totally wrong on this. I think your
original code was fine. Sorry Eduardo and Greg.
This is a threaded IRQ so the regular spin_lock is fine or even the
mutex would have been.
IRQ_ONESHOT is about triggering a second IRQ before the first one
has been finished, btw.
I am an idiot.
regards,
dan carpenter
More information about the devel
mailing list