[PATCH] staging: nvec: fix the '&&' vs '&' typo in nvec_toggle_global_events()

Marc Dietrich marvin24 at gmx.de
Sat Mar 16 21:33:24 UTC 2013


Hi Yongjun,

On Saturday 16 March 2013 22:51:25 Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> 
> Fix the '&&' vs '&' typo.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> ---
>  drivers/staging/nvec/nvec.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index cf15936..a88959f 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -352,10 +352,10 @@ static void nvec_toggle_global_events(struct nvec_chip *nvec, bool state)
>   */
>  static void nvec_event_mask(char *ev, u32 mask)
>  {
> -	ev[3] = mask >> 16 && 0xff;
> -	ev[4] = mask >> 24 && 0xff;
> -	ev[5] = mask >> 0  && 0xff;
> -	ev[6] = mask >> 8  && 0xff;
> +	ev[3] = mask >> 16 & 0xff;
> +	ev[4] = mask >> 24 & 0xff;
> +	ev[5] = mask >> 0  & 0xff;
> +	ev[6] = mask >> 8  & 0xff;
>  }
>  
>  /**

yes, this was obviously wrong. Thanks for fixing!

Acked-By: Marc Dietrich <marvin24 at gmx.de>





More information about the devel mailing list