[PATCH 00/13] staging: comedi: new driver for Advantech PCI-1724U

[Ian Abbott]

On 2013-02-19 13:59, Ian Abbott wrote:
> On 2013-02-19 13:09, Ian Abbott wrote:
>> Add a new comedi driver for the Advantech PCI-1724U submitted by Frank
>> Mori Hess.  Patch 01 is the driver more or less as submitted by Frank,
>> but with checkpatch fixes and fixes to make it compile against Greg's
>> current staging-next branch.  Patch 02 makes auto-configuration work for
>> the latest kernels and removes support for manual configuration.  The
>> remaining patches are various tweaks and tidy-ups.
>>
>> 01) staging: comedi: adv_pci1724: new driver
>
> Now at v2 to fix a missing `if (ret)` spotted by Dan Carpenter.
>
>> 02) staging: comedi: adv_pci1724: use auto_attach method
>> 03) staging: comedi: adv_pci1724: use dev->iobase
>> 04) staging: comedi: adv_pci1724: get rid of board_id
>> 05) staging: comedi: adv_pci1724: use comedi_pci_auto_unconfig directly
>> 06) staging: comedi: adv_pci1724: rename driver_* funcs and vars
>> 07) staging: comedi: adv_pci1724: use module_comedi_pci_driver()
>> 08) staging: comedi: adv_pci1724: index subdevices as array
>> 09) staging: comedi: adv_pci1724: use local pointer to private data
>> 10) staging: comedi: adv_pci1724: remove inline specifiers
>> 11) staging: comedi: adv_pci1724: return insn->n
>> 12) staging: comedi: adv_pci1724: use individual channel ranges
>
> Those should still apply.
>
>> 13) staging: comedi: adv_pci1724: avoid forward declarations
>
> Now at v2 as it moves the function fixed in v2 of patch 01.
>
> Sorry for the cock-up.  With the number of times I tweaked and reordered
> this series of patches, I should have spotted it earlier!

I was thinking of squashing these 13 patches (including the two v2 
patches) into a single patch, since adding 13 patches for a single new 
driver seems a bit much.  Is that a good idea or not?  Thanks.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-