Possible bug in vme_tsi148 in enabling CR/CSR space

De Roo, Steven steven.deroo at arcelormittal.com
Tue Jun 11 11:43:23 UTC 2013


This is an abstract from vme_tsi148.c:

...
2296         crat = ioread32be(bridge->base + TSI148_LCSR_CRAT);
2297         if (crat & TSI148_LCSR_CRAT_EN) {
2298                 dev_info(tsi148_bridge->parent, "Enabling CR/CSR space\n");
2299                 iowrite32be(crat | TSI148_LCSR_CRAT_EN,
2300                         bridge->base + TSI148_LCSR_CRAT);
2301         } else
2302                 dev_info(tsi148_bridge->parent, "CR/CSR already enabled\n");
...

Shouldn't this be like this ?

...
2297		if (!(crat & TSI148_LCSR_CRAT_EN))
...

Kind regards, 
Steven De Roo



More information about the devel mailing list