VME-driver: Memory leak in module 'vme.c', function 'vme_dma_free'

Dan Carpenter dan.carpenter at oracle.com
Wed Jun 5 19:48:04 UTC 2013


On Mon, Jun 03, 2013 at 09:57:22AM +0000, De Roo, Steven wrote:
> Dear Martyn,
> 
> I think there is a memory leak in module 'vme.c', function 'vme_dma_free'.
> 'kfree(resource)' is not called after unlocking the mutex...

[ snip]

> PS: I found out about this after performing lots of DMA-transfers,
> which finally lead to out-of-memory problems and a system freeze...
> Using 'slabinfo', I can now see that the problem is gone with this fix.

It seems like you are using an out of tree driver?  The
vme_dma_free() function is never called so adding a kfree()
shouldn't change anything.  But it would make it match vme_lm_free()
and vme_master_free() so it's probably the right thing I suppose.

regards,
dan carpenter



More information about the devel mailing list