[PATCH 0/5] Radio device framework

[Goyal Akhil-B35197]

-----Original Message-----
From: Greg KH [mailto:gregkh at linuxfoundation.org] 
Sent: Tuesday, June 04, 2013 8:34 PM
To: Goyal Akhil-B35197
Cc: devel at driverdev.osuosl.org
Subject: Re: [PATCH 0/5] Radio device framework

On Tue, Jun 04, 2013 at 02:34:55PM +0530, akhil.goyal at freescale.com wrote:
> From: Akhil Goyal <akhil.goyal at freescale.com>
> 
> RF signal path is integral part of any system that transmits/receives 
> RF (radio frequency) signals. In these systems Data is 
> processed/converted to IQ samples (digital representation a RF signal) 
> and passed to a RFIC (RF PHY) which converts the digital RF signal (IQ 
> samples) to analog and transmits over antenna.
> 
> Typically The signal path consists of multiple components: 
> 
> Antenna controller <-> vector signal processors <-> RFIC <-> Antenna
> 
> Each of these components have specific functionalities: 
> 
> 1. Antenna controller: Framing of digital IQ data into protocol specific frames.
> 2. vector signal processors: For conditioning of signal.
> 3. RFIC : converts digital IQ data to analog signal which is transmitted/received on/from Air.
> 
> Also it is desirable to control the complete signal path, for example:
> bringing the complete signal path up/down etc. 
> 
> The radio device framework introduces a way to accommodate the RF 
> signal paths.  One signal path is represented as a RF device (rf0, rf1 
> etc), and it can contain multiple components which have their 
> individual vendor specific drivers. The framework provides mechanism 
> by which individual components can register with RF framework, and the 
> framework will handle the binding of individual component devices to a 
> RF device. RF device exports the control interfaces to user space, and 
> this user space interface is independent of component (vendor specific) drivers.
> 
> This patch set include
> 1. RF Interface: Independent of phy or antenna controller.
> 2. AIC driver: Antenna interface Controller(AIC) of Hetrogenous SOC's 
> like BSC9131, BSC9132 3. AD9361 driver: RF Phy driver for Analog 
> Devices(ADI) chip(AD9361) 4. Device tree bindings for AIC and ADI 
> nodes.
> 5. Device tree changes for BSC9131
> 
> This framework will be re-sent for drivers/ folder after it gets 
> approval for staging.

What does this sentance mean?

Why are you submitting this for drivers/staging/?  I do not see a TODO file that lists what needs to be done to this code to get it out of the staging tree, that is required.
[Akhil] yes this driver do not have any TODO file but as per my understanding, any new driver shall be first sent to staging folder but if it is ok to send the patches directly to drivers/ folder then I will resend this patch set by rebasing it to drivers/ folder.

>  .../devicetree/bindings/rf/ad9361-phy.txt          |   53 +
>  Documentation/devicetree/bindings/rf/fsl-aic.txt   |   47 +
>  arch/powerpc/boot/dts/bsc9131rdb.dts               |    4 +
>  arch/powerpc/boot/dts/bsc9131rdb.dtsi              |   38 +
>  arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi      |   53 +-
>  arch/powerpc/boot/dts/fsl/pq3-espi-0.dtsi          |    1 +
>  arch/powerpc/boot/dts/fsl/pq3-espi-1.dtsi          |   42 +
>  arch/powerpc/boot/dts/fsl/pq3-gpio-0.dtsi          |    1 +
>  arch/powerpc/boot/dts/fsl/pq3-gpio-1.dtsi          |   42 +
>  drivers/staging/Kconfig                            |    2 +
>  drivers/staging/Makefile                           |    1 +
>  drivers/staging/rf/Kconfig                         |   37 +
>  drivers/staging/rf/Makefile                        |    7 +
>  drivers/staging/rf/controllers/Makefile            |    1 +
>  drivers/staging/rf/controllers/fsl_aic.c           | 1560 ++++++++++++++++
>  drivers/staging/rf/controllers/fsl_aic.h           |  450 +++++
>  drivers/staging/rf/core/Makefile                   |    2 +
>  drivers/staging/rf/core/rf_channel.c               |  207 +++
>  drivers/staging/rf/core/rfdev.c                    | 1263 +++++++++++++
>  drivers/staging/rf/phy/Makefile                    |    2 +
>  drivers/staging/rf/phy/ad9361.c                    | 1918 ++++++++++++++++++++
>  drivers/staging/rf/phy/ad9361.h                    |  353 ++++
>  include/linux/rf_channel.h                         |   26 +
>  include/linux/rfdev.h                              |  250 +++
>  include/uapi/linux/rfdev.h                         |  392 ++++

Code in drivers/staging/ has to be self-contained, no extra files in include/linux/ or anywhere else if at all possible.

So as-is, I can't take this at all, please provide more information as to why you want me to take this, and then fix it up to be self-contained.
[Akhil] I will resend the patches after rebasing it to drivers/ folder if it is ok?

thanks,

greg k-h