[PATCH 1/5] rtl8192u: remove dead and commented-out code in r8192U_core.c

Greg KH gregkh at linuxfoundation.org
Mon Jun 3 20:24:42 UTC 2013


On Mon, Jun 03, 2013 at 10:53:03PM +0300, Xenia Ragiadakou wrote:
> On 06/03/2013 10:48 PM, Greg KH wrote:
> >On Mon, Jun 03, 2013 at 10:34:58PM +0300, Xenia Ragiadakou wrote:
> >>This cleanup patch removes commented-out code and
> >>the functions rtl8192_dump_reg() and print_buffer()
> >>which are not called anywhere in the driver.
> >>
> >>Signed-off-by: Xenia Ragiadakou<burzalodowa at gmail.com>
> >Please put "staging:" in your subject: lines, so I don't have to do it
> >by hand by myself.  It also ensures it gets routed to the proper mailbox
> >on my machine...
> >
> >And what about the acks that Dan provided for this series, what happened
> >to them?
> >
> >Care to resend with the subject changed, and the acks added to them?
> >
> >thanks,
> >
> >greg k-h
> 
> Ok I will fix the subject line.
> 
> When you are refering to acks you mean the email
> that sent by Dan saying:
> 
> All five:
> 
> Reviewed-by: Dan Carpenter<dan.carpenter at oracle.com>
> 
> Where should I add the acks?

Sorry, I forgot it was a "reviewed-by:".  But that on the line below
your signed-off-by: line in all of the patches.

thanks,

greg k-h



More information about the devel mailing list