[PATCH v3 4/4] tools: hv: Fix file descriptor leaks

[KY Srinivasan]

> -----Original Message-----
> From: Tomas Hozza [mailto:thozza at redhat.com]
> Sent: Wednesday, May 22, 2013 8:55 AM
> To: gregkh at linuxfoundation.org
> Cc: KY Srinivasan; jasowang at redhat.com; Haiyang Zhang;
> devel at linuxdriverproject.org; Tomas Hozza
> Subject: [PATCH v3 4/4] tools: hv: Fix file descriptor leaks
> 
> Close "fd" file descriptor when is goes out of scope so it does
> not leak.
> 
> Signed-off-by: Tomas Hozza <thozza at redhat.com>
Acked-by:  K. Y. Srinivasan <kys at microsoft.com>

> ---
>  tools/hv/hv_kvp_daemon.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index 5b8f28f..d55ce40 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -257,12 +257,15 @@ static int kvp_file_init(void)
> 
> 
>  		filep = fopen(fname, "re");
> -		if (!filep)
> +		if (!filep) {
> +			close(fd);
>  			return 1;
> +		}
> 
>  		record = malloc(alloc_unit * num_blocks);
>  		if (record == NULL) {
>  			fclose(filep);
> +			close(fd);
>  			return 1;
>  		}
>  		for (;;) {
> @@ -286,6 +289,7 @@ static int kvp_file_init(void)
>  						num_blocks);
>  				if (record == NULL) {
>  					fclose(filep);
> +					close(fd);
>  					return 1;
>  				}
>  				continue;
> --
> 1.8.1.4
> 
>