[PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

Ben Chan benchan at chromium.org
Mon Jun 3 18:18:21 UTC 2013


Sorry, I meant to send the revised patch but got the wrong file.

I'll add the Reported-by field.

Thanks,
Ben

On Mon, Jun 3, 2013 at 10:48 AM, Greg Kroah-Hartman
<gregkh at linuxfoundation.org> wrote:
> On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote:
>> The gdm72xx driver needs to have either the USB or SDIO implementation
>> enabled to provide useful functionalities, so the driver should depend
>> on either USB or MMC.
>>
>> Signed-off-by: Ben Chan <benchan at chromium.org>
>> Cc: Sage Ahn <syahn at gctsemi.com>
>> ---
>>  drivers/staging/gdm72xx/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
>> index 6905913..8af0dd4 100644
>> --- a/drivers/staging/gdm72xx/Kconfig
>> +++ b/drivers/staging/gdm72xx/Kconfig
>> @@ -4,7 +4,7 @@
>>
>>  menuconfig WIMAX_GDM72XX
>>       tristate "GCT GDM72xx WiMAX support"
>> -     depends on NET
>> +     depends on NET && (USB || MMC)
>
> Alan Stern already told you how this would not solve the problem, why
> did you resend it to me again?
>
> And you forgot the "Reported-by:" line above, giving proper credit to
> the person who told you about this problem.
>
> Please fix both of them and resend.
>
> thanks,
>
> greg k-h



More information about the devel mailing list