[PATCH] HID: hyperv: Cocci spatch "memdup.spatch"
Jiri Kosina
jkosina at suse.cz
Mon Jun 3 11:34:38 UTC 2013
On Sat, 1 Jun 2013, Thomas Meyer wrote:
> Signed-off-by: Thomas Meyer <thomas at m3y3r.de>
> ---
>
> diff -u -p a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -199,13 +199,11 @@ static void mousevsc_on_receive_device_i
> if (desc->bLength == 0)
> goto cleanup;
>
> - input_device->hid_desc = kzalloc(desc->bLength, GFP_ATOMIC);
> + input_device->hid_desc = kmemdup(desc, desc->bLength, GFP_ATOMIC);
>
> if (!input_device->hid_desc)
> goto cleanup;
>
> - memcpy(input_device->hid_desc, desc, desc->bLength);
> -
> input_device->report_desc_size = desc->desc[0].wDescriptorLength;
> if (input_device->report_desc_size == 0) {
> input_device->dev_info_status = -EINVAL;
>
I guess you are going to get some pushback from some maintainers due to
non-descriptive subject and missing changelog :)
I have fixed this for the hyperv patch and applied it, thanks.
--
Jiri Kosina
SUSE Labs
More information about the devel
mailing list