[PATCH 1/3] rtl8192e cleanups

[Sean MacLennan]

On Fri, 31 May 2013 09:37:02 +0300
Dan Carpenter <dan.carpenter at oracle.com> wrote:

> I just had a patch go in here yesterday so these don't apply any
> more, sorry.

I will fix that.

> > +#if 0
> >  struct phy_ofdm_rx_status_rxsc_sgien_exintfflag {
> >  	u8			reserved:4;
> >  	u8			rxsc:2;
> >  	u8			sgi_en:1;
> >  	u8			ex_intf_flag:1;
> >  };
> > +#endif
> 
> Didn't you just want to delete this?  The patch ifdefs out some
> other code below as well.

No. I wanted to keep it as documentation just in case. But I wanted to
be sure nobody was using it. What is normal practice here, delete and
say you can always look it up in the older code?

> 
> > @@ -288,57 +231,11 @@ static	void
> > cmpk_handle_tx_status(struct net_device *dev, u8 *pmsg) {
> >  	struct cmpk_tx_status rx_tx_sts;	/* */
> >  
> > +	// SAM FIXME
> 
> Get on the ball, Sam!

OUCH! SAM will fix that in the next iteration ;)

> 
> >  	memcpy((void *)&rx_tx_sts, (void *)pmsg, sizeof(struct
> > cmpk_tx_status)); cmpk_count_tx_status(dev, &rx_tx_sts);
> >  }
> > @@ -1598,7 +1593,6 @@ static void rtl8192_query_rxphystatus(
> >  			tmp_rxsnr = pofdm_buf->rxsnr_X[i];
> >  			rx_snrX = (char)(tmp_rxsnr);
> >  			rx_snrX /= 2;
> > -			priv->stats.rxSNRdB[i] = (long)rx_snrX;
> 
> The rx_snrX variable isn't needed now.

Yup. I will fix that to.

Probably won't get around to it until Saturday.

Cheers,
    Sean