[PATCH] staging: comedi: allow ISA and PC/104 drivers on non-ISA systems

Ian Abbott abbotti at mev.co.uk
Tue Jul 30 09:03:52 UTC 2013


On 2013-07-30 01:59, H Hartley Sweeten wrote:
> On Friday, July 26, 2013 3:09 AM, Ian Abbott wrote:
>> On 2013-07-26 00:32, H Hartley Sweeten wrote:
>>> On Thursday, July 25, 2013 3:43 AM, Ian Abbott wrote:
>>>> On 2013-07-24 19:24, H Hartley Sweeten wrote:
>
> <snip>
>
>>>>>     menuconfig COMEDI_ISA_DRIVERS
>>>>>     	bool "Comedi ISA and PC/104 drivers"
>>>>> -	depends on ISA
>>>>> +	depends on ISA || COMEDI_ENABLE_ISA
>
> <snip>
>
>> You're probably right, but in that case there should be an option to
>> enable ISA support higher up than comedi.
>>
>> Besides, the boolean option COMEDI_ENABLE_ISA seems unnecessary as you
>> could achieve the same effect by making the COMEDI_ISA_DRIVERS menu
>> option not depend on ISA (except you'd only have to enable one
>> configuration option then instead of two).
>
> Would you prefer to just drop the 'depends on ISA' for the
> COMEDI_ISA_DRIVERS option?

I'm okay with that but would like Greg's opinion.  None of them depend 
on ISA for building.  A few depend on ISA_DMA_API for building, but 
x86_64 has that as a configuration option.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-


More information about the devel mailing list